search

otrv4 / pidgin-otrng

Fork of https://bugs.otr.im/plugins/pidgin-otr. This is a mirror of https://bugs.otr.im/otrv4/pidgin-otrng
GNU General Public License v2.0
16 stars 5 forks source link

Crash at start #2 #84

Closed claucece closed 5 years ago

claucece commented 5 years ago

It crashes at:

(18:58:36) jabber: jabber_actions: have pep: YES
otrng_client_ensure_correct_state(client=bob@localhost)
Assertion failed: (ret), function gf_invert, file goldilocks.c, line 76.

Thread 2 received signal SIGABRT, Aborted.
0x00007fff50a19e3e in ?? ()
claucece commented 5 years ago

Somehow the prekey profile does not get written and causes this crash.

olabini commented 5 years ago

Wow, that's very very strange. This problem went away for me after I removed the "generating private key" dialog. Are you still getting it with the latest of everything?

claucece commented 5 years ago

Yeah.. I just fixed.. see why in libotr-ng.. the two last commits.

claucece commented 5 years ago

But let me know if everything works for you with the newest changes. This was introduced by the latest refactorings to prekey profile.

olabini commented 5 years ago

You're talking about https://github.com/otrv4/libotr-ng/commit/63a869fdb05c8d461fcca5c7161545a4c8217bb4 and https://github.com/otrv4/libotr-ng/commit/a8c6bf95e54b83af057c15e5e23671281a043b3f, right?

I think that setting client->prekey_profile = NULL; is what fixed the crash. I'm not sure I understand how otrng_prekey_profile_destroy(profile); fixed anything (except a memory leak).

But about setting prekey_profile to NULL, I did the same for client profile, and that fixed a problem I had.

claucece commented 5 years ago

Yeah.. I'm very unsure.. but well.