Persistent values not been generated

otrv4 / pidgin-otrng

Fork of https://bugs.otr.im/plugins/pidgin-otr. This is a mirror of https://bugs.otr.im/otrv4/pidgin-otrng

GNU General Public License v2.0

16 stars 5 forks source link

Persistent values not been generated #85

Open claucece opened 5 years ago

claucece commented 5 years ago

The persistent values are not generated or published in this case:

Bob does not have the otr-ng plugin active
Bob logs in in his account
Bob activates the otr-ng plugin

olabini commented 5 years ago

Ah, yes. I think that's because the signed-on event is used to generate values, but since the sign-on happens before the plugin is active, no such event ever happens. We have two reasonable alternatives here:

Check for already active accounts when the plugin is enabled, and init them manually
Wait until the ensure_-mechanism is ready. This will make sure to create the needed values before they are needed to use, no matter if it's at sign-on or at some other time.

claucece commented 5 years ago

Mmmm:

Wait until the ensure_-mechanism is ready. This will make sure to create the needed values before they are needed to use, no matter if it's at sign-on or at some other time.

Yeah, let's see.

olabini commented 5 years ago

This issue can now be picked up to fix.

claucece commented 5 years ago

Thanks @olabini

olabini commented 5 years ago

If you feel like checking if this still happen, that would be great. I think it should be fine now.

olabini commented 5 years ago

I'll take a look and see.