otrv4 / pidgin-otrng

Fork of https://bugs.otr.im/plugins/pidgin-otr. This is a mirror of https://bugs.otr.im/otrv4/pidgin-otrng
GNU General Public License v2.0
16 stars 5 forks source link

Fingerprint verification - the privacy status changes too early #94

Closed olabini closed 5 years ago

olabini commented 6 years ago

When doing manual fingerprint verification, you switch the drop down from "I have not" to "I have". At this point the plugin will switch the privacy status to "Private", print this to the conversation window, and print "trusted" in the otr4.fingerprints file. This all happens BEFORE the "authenticate" button has been pressed.

Correct behavior should be to not do anything until the "authenticate" button is pressed.

claucece commented 6 years ago

I see, definitely a problem.

claucece commented 6 years ago

Adding to this, on the configuration panel, you can also verify the fingerprint of the buddy, so we should always test that this works too.

screen shot 2018-10-02 at 1 55 28 pm
olabini commented 6 years ago

I'll reopen the "Q/A" fingerprint issue and add it there.

olabini commented 6 years ago

This issue ALSO applies to the configuration panel (when switch "I have" to "I have not" for example), the value immediately changes, before pressing the "OK" button