otrv4 / pidgin-otrng

Fork of https://bugs.otr.im/plugins/pidgin-otr. This is a mirror of https://bugs.otr.im/otrv4/pidgin-otrng
GNU General Public License v2.0
16 stars 5 forks source link

Show the ssid #99

Closed claucece closed 4 years ago

claucece commented 5 years ago

The secure session ID (SSID) is a 8-byte value. It is used to to verify (over the telephone, assuming the parties recognize each others' voices) that there is no man-in-the-middle. it should be displayed in this way, as described in the protocol:

For example, in C language, in "%08x" format. If the party transmitted the Auth-R message during 
the DAKE, then display the first 4 bytes in bold, and the second 4 bytes in non-bold. If the party
transmitted the Auth-I message instead, display the first 4 bytes in non-bold, and the second 4 bytes
in bold. If the party transmitted the Non-Interactive-Auth message during the DAKE, then display the
first 4 bytes in bold, and the second 4 bytes in non-bold. If the party received the 
Non-Interactive-Auth message instead, display the first 4 bytes in non-bold, and the second 4 bytes 
in bold.

It should be somehow shown in the UI of the plugin.

MauroVelasco commented 5 years ago

Hi @claucece,

I'm showing the SSID in the following way:

i99_1

And the information about SSID is shown in a dialog, when the user click on SSID link:

i99_2

Can we show the SSID in that way?

claucece commented 5 years ago

Awesome! Looks perfect!

MauroVelasco commented 4 years ago

Hi @claucece,

The final version as suggested looks like this:

i99_3

claucece commented 4 years ago

@MauroVelasco .. check that I did in the last commit ;)

MauroVelasco commented 4 years ago

Great, thks @claucece for the improvement

MauroVelasco commented 4 years ago

Hi @claucece,

The option to show/hide ssid info is:

ss_config_show_ssid

Let me know if that location is fine

pedropalau commented 4 years ago

I would recommend this option to be unchecked by default and use a more intuitive name like:

[X] Show the SSID in the conversation window
MauroVelasco commented 4 years ago

This is the final screenshot of the configuration property.

ss_config_show_ssid_2

claucece commented 4 years ago

Perfect! Closing this ;)