otsaloma / poor-maps

Maps and navigation for Sailfish OS
https://openrepos.net/content/otsaloma/poor-maps
GNU General Public License v3.0
43 stars 10 forks source link

Update deps for Sailfish OS 2.0.5 #29

Closed ilpianista closed 7 years ago

ilpianista commented 7 years ago

qt5-plugin-geoservices-nokia has been renamed as qt5-plugin-geoservices-here.

otsaloma commented 7 years ago

I haven't installed 2.0.5 yet, so I can't test. Did you test that your fix works? Is it really just the package name changed, not the API -- e.g. the plugin name?

ilpianista commented 7 years ago

Nope, I didn't test it. I thought it was only the package name that is changed.

I'll try test it this evening.

otsaloma commented 7 years ago

It's hard to tell from the version number, but it's likely that they have backported the API changes of the HERE plugin, which would mean the name "here" and "here." prefixes on the parameter names.

http://doc.qt.io/qt-5/location-plugin-here.html#parameters

I'll probably upgrade and test on the weekend.

otsaloma commented 7 years ago

There was a small API change: app_code instead of token. With that change it works. Merging.