ott-jax / ott

Optimal transport tools implemented with the JAX framework, to get differentiable, parallel and jit-able computations.
https://ott-jax.readthedocs.io
Apache License 2.0
524 stars 80 forks source link

implements sliced W #576

Closed marcocuturi closed 2 months ago

marcocuturi commented 2 months ago

Fairly primitive implementation of sliced_w distance.

essentially a wrapper on top of the ott.solvers.linear.solve_univariate function

codecov[bot] commented 2 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 87.84%. Comparing base (4aed3ec) to head (46bd3dd). Report is 1 commits behind head on main.

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/ott-jax/ott/pull/576/graphs/tree.svg?width=650&height=150&src=pr&token=14PUIHGLV9&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ott-jax)](https://app.codecov.io/gh/ott-jax/ott/pull/576?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ott-jax) ```diff @@ Coverage Diff @@ ## main #576 +/- ## ========================================== + Coverage 87.78% 87.84% +0.05% ========================================== Files 72 73 +1 Lines 7801 7823 +22 Branches 1126 1127 +1 ========================================== + Hits 6848 6872 +24 + Misses 802 798 -4 - Partials 151 153 +2 ``` | [Files with missing lines](https://app.codecov.io/gh/ott-jax/ott/pull/576?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ott-jax) | Coverage Δ | | |---|---|---| | [src/ott/tools/sliced.py](https://app.codecov.io/gh/ott-jax/ott/pull/576?src=pr&el=tree&filepath=src%2Fott%2Ftools%2Fsliced.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ott-jax#diff-c3JjL290dC90b29scy9zbGljZWQucHk=) | `100.00% <100.00%> (ø)` | | ... and [1 file with indirect coverage changes](https://app.codecov.io/gh/ott-jax/ott/pull/576/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ott-jax)
review-notebook-app[bot] commented 2 months ago

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

marcocuturi commented 2 months ago

Thanks a lot @michalk8 for all these great comments!