search

ott-jax / ott

Optimal transport tools implemented with the JAX framework, to get differentiable, parallel and jit-able computations.
https://ott-jax.readthedocs.io
Apache License 2.0
524 stars 80 forks source link

Wrong implementation of u_t(x|z) in Brownian Bridge #595

Open selmanozleyen opened 5 days ago

selmanozleyen commented 5 days ago

Hi, I was reading the tong et al 23 paper and noticed the implementation might be wrong here. As I was using this flow for my thesis project already.

In the implementation ut() = x1-x0 but in the paper it is image

https://github.com/ott-jax/ott/blob/828acca41a0c41ce38440ad51896e5c29161cbbd/src/ott/neural/methods/flows/dynamics.py#L143

MUCDK commented 4 days ago

Good point @selmanozleyen , can you open a PR?