search

ottacom / blockly

Automatically exported from code.google.com/p/blockly
0 stars 0 forks source link

Enable errors for closure compilation #109

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
What steps will reproduce the problem?
1.Call a function with incorrect parameters

What is the expected output? What do you see instead?
Expect a failure to compile; instead it goes through fine and just calls 
incorrectly.

Enabling errors would catch problems like Bug 108 before they get committed.

Original issue reported on code.google.com by s...@google.com on 2 Feb 2013 at 4:13

GoogleCodeExporter commented 9 years ago 
Revision: 614
Author:   scr@google.com
Date:     Sun Feb  3 10:36:14 2013
Log:      Added some jscomp_error flags & fixed errors.

TBR=neil.fraser@gmail.com
BUG=109

Review URL: https://codereview.appspot.com/7277046
http://code.google.com/p/blockly/source/detail?r=614

Added:
 /trunk/Make.jscomp
Modified:
 /trunk/Makefile
 /trunk/blockly_compressed.js
 /trunk/blockly_core_deps.js
 /trunk/core/blockly.js
 /trunk/core/toolbox.js

Original comment by s...@google.com on 6 Feb 2013 at 5:42

GoogleCodeExporter commented 9 years ago 
Revision: 615
Author:   scr@google.com
Date:     Sun Feb  3 12:16:03 2013
Log:      Fix errors related to invalidCasts.

TBR=neil.fraser@gmail.com
BUG=109

Review URL: https://codereview.appspot.com/7277049
http://code.google.com/p/blockly/source/detail?r=615

Modified:
 /trunk/Make.jscomp
 /trunk/blockly_compressed.js
 /trunk/blockly_core.js
 /trunk/blockly_core_deps.js
 /trunk/core/block.js
 /trunk/core/blockly.js
 /trunk/core/bubble.js
 /trunk/core/field_colour.js
 /trunk/core/field_image.js
 /trunk/core/field_textinput.js
 /trunk/core/flyout.js
 /trunk/core/scrollbar.js
 /trunk/core/svg_component.js
 /trunk/core/toolbox.js
 /trunk/core/trashcan.js
 /trunk/core/utils.js
 /trunk/core/variables.js
 /trunk/requireprovides.py

Original comment by s...@google.com on 6 Feb 2013 at 5:43

GoogleCodeExporter commented 9 years ago 
Revision: 621
Author:   scr@google.com
Date:     Tue Feb  5 21:39:53 2013
Log:      Created externs to allow checkTypes to be enabled.

TBR=neil.fraser@gmail.com
BUG=109

Review URL: https://codereview.appspot.com/7307045
http://code.google.com/p/blockly/source/detail?r=621

Added:
 /trunk/core/metrics.js
 /trunk/externs
 /trunk/externs/gen
 /trunk/externs/gen/gen.pl
 /trunk/externs/gen/svg.conf
 /trunk/externs/html5.js
 /trunk/externs/messages.js
 /trunk/externs/svg.js
Modified:
 /trunk/Make.jscomp
 /trunk/Makefile
 /trunk/blockly_compressed.js
 /trunk/blockly_core.js
 /trunk/blockly_core_deps.js
 /trunk/core/block.js
 /trunk/core/block_svg.js
 /trunk/core/blockly.js
 /trunk/core/bubble.js
 /trunk/core/comment.js
 /trunk/core/connection.js
 /trunk/core/contextmenu.js
 /trunk/core/field.js
 /trunk/core/field_dropdown.js
 /trunk/core/generator.js
 /trunk/core/procedures.js
 /trunk/core/scrollbar.js
 /trunk/core/toolbox.js
 /trunk/core/tooltip.js
 /trunk/core/utils.js
 /trunk/core/variables.js
 /trunk/core/warning.js
 /trunk/core/workspace.js
 /trunk/language/en/_messages.js

Original comment by s...@google.com on 6 Feb 2013 at 5:43

GoogleCodeExporter commented 9 years ago 
Revision: 622
Author:   scr@google.com
Date:     Tue Feb  5 22:01:33 2013
Log:      Made compile depend on generated externs so make clean all works.

Also created constents for gen.pl.

TBR=neil.fraser@gmail.com
BUG=109

Review URL: https://codereview.appspot.com/7309055
http://code.google.com/p/blockly/source/detail?r=622

Modified:
 /trunk/Makefile
 /trunk/externs/gen/gen.pl
 /trunk/externs/svg.js

Original comment by s...@google.com on 6 Feb 2013 at 6:08

GoogleCodeExporter commented 9 years ago 
Revision: 623
Author:   scr@google.com
Date:     Tue Feb  5 22:05:56 2013
Log:      Added duplicate and missingProperties errors.

TBR=neil.fraser@gmail.com
BUG=109

Review URL: https://codereview.appspot.com/7306050
http://code.google.com/p/blockly/source/detail?r=623

Modified:
 /trunk/Make.jscomp

Original comment by s...@google.com on 6 Feb 2013 at 6:08

GoogleCodeExporter commented 9 years ago 
I think this is as far as it goes - the accessControl and visibility are tough 
unless everyone uses @protected rather than @private and many of the goog. 
files don't honor this; I'm closing now.

Original comment by s...@google.com on 6 Feb 2013 at 6:10