otto-de / api-guidelines

A set of rules to build consistent and high quality REST and Async APIs at OTTO.
https://api.otto.de/portal/guidelines
Creative Commons Attribution 4.0 International
46 stars 14 forks source link

docs(checklist): add pr review checklist #49

Closed BirgitBader closed 1 year ago

BirgitBader commented 1 year ago

Relates to ottoapi_docs otto-ec/ottoapi_orga#91

Adds checklist to review a pull request in the api-guidelines repository.

DominiquePetrich1709 commented 1 year ago

Maybe something like:

BirgitBader commented 1 year ago

Maybe something like:

  • Is the change in line with our API guidelines?

@DominiquePetrich1709 Thanks! Is this a suggestion for this API Guidelines checklist or for an ottoapi_docs review?

DominiquePetrich1709 commented 1 year ago

Maybe something like:

  • Is the change in line with our API guidelines?

@DominiquePetrich1709 Thanks! Is this a suggestion for this API Guidelines checklist or for an ottoapi_docs review?

@BirgitBader It's for the pr review checklist.