search

ottomatic-io / pycine

Reading Vision Research .cine files with python
GNU Lesser General Public License v3.0
26 stars 19 forks source link

release a new version for PiPy #21

Open SReich-EMI opened 3 years ago

SReich-EMI commented 3 years ago

Is it possible to release a new version for PiPy with the recent changes, so that all can profit from the improvements?

cbenhagen commented 3 years ago

I will release a new version soon. I stumbled about some small things that I would want to fix before a release. Also I would want to add at least some basic unit- and end-to-end tests to make sure everything works. Would you be able to send me a sample .cine with 12 bit packing?

If someone can't wait for the new features the package can always be pip-installed directly from the git master branch.

blakeNaccarato commented 1 year ago

The version at https://github.com/ottomatic-io/pycine/tree/master works very well for my use-case. Thanks for putting in the work, all the low-level bit-banging you've got to do makes my head hurt! And I'm sorry I don't have any 12-bit packing test cases for you.

Any chance for a small point release that rolls up the latest changes at https://github.com/ottomatic-io/pycine/tree/master into the PyPi release? I'm installing from https://github.com/ottomatic-io/pycine/tree/master as you recommended, for now.

A separate concern I have (let me know if you'd like me to raise an Issue on it) is that I have to install --no-deps because I'm using opencv-contrib-python and the requirement of opencv-python on pycine clobbers my contrib package. Perhaps setup.py could be modified to not bundle OpenCV with default pip install pycine, then have options like pip install pycine[opencv-python] and pip install pycine[opencv-python-contrib]? There are other ways to go about it, besides that. I know it's a bit ugly dealing with different distributions of opencv-python in the same environment, I'm not really sure of the best-practice recommendation! But I can do the legwork on figuring out the best practice and raise an Issue on that if you're interested in pursuing it.