ottopaulsen / node-red-contrib-power-saver

A Node-RED node to saver money by turning off when the power is most expensive
Other
71 stars 17 forks source link

NaN as setpoint when price is missing for the day after #131

Closed zyberzero closed 1 year ago

zyberzero commented 1 year ago

I've imported the flow for heat-capacitor and adapted it to my house, time+1C is 480 and time-1C is set to 360.

I'm using Tibber as the price source, and I am in SE3.

It works fine as long as I have price info for the next day, but when the list of trades ends on day 2 at around 07:00 - and no price info is available for day 3 - it sets the setpoint to NaN which the rest of the system interprets as 0.0 🥶

I'd expect it to set the setpoint to "sell" mode.

I am probably doing something wrong, and need enlightenment but I think that I've followed the instructions.

This happened for example today, with the output from the heat-capacitor node can be found here

TomTorger commented 1 year ago

Ouch... Sorry ❄️ Sounds like a serious bug. I will make a test and try to re-create it :-)

Thanks for providing the output! 🥇

TomTorger commented 1 year ago

I changed the way the current values are fetched, and the new PR should fix this issue once it is merged :-)

zyberzero commented 1 year ago

Awesome, thanks for looking into it! I'll test it as soon it is released :)

zyberzero commented 1 year ago

I tested the latest version and it seems to work now. Thank you!