search

ottosmops / hash

create and verify hash files
MIT License
1 stars 1 forks source link

Consider fix test method name via PSR-2 coding style #2

Open peter279k opened 4 years ago

peter279k commented 4 years ago

As title, when using the composer check-style for PHP classes on `tests folder, it will present following errors:

.......
FILE: /data/hash/tests/Md5sumTest.php
--------------------------------------------------------------------------------
FOUND 10 ERRORS AND 1 WARNING AFFECTING 11 LINES
--------------------------------------------------------------------------------
  25 | ERROR   | Method name "HashTest::it_can_validate_a_validate_manifest" is
     |         | not in camel caps format
  33 | ERROR   | Method name
     |         | "HashTest::it_can_validate_a_validate_sh1_manifest" is not in
     |         | camel caps format
  43 | ERROR   | Method name
     |         | "HashTest::it_can_validate_a_validate_manifest_binary" is not
     |         | in camel caps format
.......

IMHO, we should consider changing into method name to follow camel-case style.

For example, it can change into: itCanCreateManifestFlat or testCanCreateManifestFlat and remove /** @test */ comment annotation.

@ottosmops, do you have any idea about this?

Once this issue is accepted, I think I can work on this :).

ottosmops commented 4 years ago

Thank you! For me the snake_case is better readable, but if you change it I will accept it.