ottowayi
commented
2 years ago thanks for this, I just have a couple questions. What spec are you referring too? I'm not seeing the same information in the Data Access Manual, but I could just be miss reading it too. And can you undo the couple of formatting/whitespace changes? I use black for formatting, although I'm not the biggest fan of the whitespace it adds to slices.
I'll do some testing with this this afternoon and get it merged soon. Also, I changed the target branch to develop. Usually I create a new one right after I publish a release, but I must've forgotten to do that.
emourzi1
pycomm3.cip.data_types.DataType description states that attributes property is "List of names for each attribute in the structure. Does not include internal tags not shown in Logix, like the host DINT tag that BOOL attributes are mapped to."
However, the current code shows hidden attributes for AOIs and UDT, where this is not happening when using Logix Designer. Proposed change will show only visible attributes. I followed the CIP spec that describes the style bytes that are returned from the controller, two bytes for each template member, and made the change to exclude them. internal_tags property still shows all structure attributes regardless of the visibility status. The tests passed with the exception of the test_demo_plc.py since I have a different controller and another version of Studio 5000.
Unfortunately, I am not able to use the develop branch as described in the "contributing guidelines" as I do not have the permission to create branches in the base repository.