search

ottowayi / pycomm3

A Python Ethernet/IP library for communicating with Allen-Bradley PLCs.
MIT License
397 stars 88 forks source link

Update vendor list #257

Closed PhilippHaefele closed 1 year ago

PhilippHaefele commented 1 year ago

Updated vendors from a vid file that was kindly provided to me from ODVA. I wrote a small python script to read the ODVA file and output in a predefined format, so i can update vendors in different tools. To preserve obsolete vendors, i issue a list of them separately.

Some company names have special UTF-8 characters like ü, ä, ç, ã and ）/ U+FF09 and I'm not sure if pycomm3 can handle them at this place in code. Can someone please acknowledge that this is ok?

There were some Reserved entries in the list. As i do not see any additional value to values that aren't in the list at all, i removed them. What do you think about that change and should i add the Reserved entries?

ottowayi commented 1 year ago

Thank you for this, this is much easier than the scraper I just wrote to pull them from the ODVA marketplace 😂. I think utf-8 is fine, since the id's are what are used in the protocol not the strings. The Reserved ones can be deleted, this list came from the original pycomm library. I plan on working on my v2 stuff a bit this weekend, so I'll work on getting this merged too.

ottowayi commented 1 year ago

Sorry, I was dealing with a sick puppy all weekend and completely forgot about this... and I'm also out of town until next week. I'll complete this when I get back.

PhilippHaefele commented 1 year ago

Thanks for commenting, but that's no problem. Hopefully the puppy is up well again. Time doesn't matter that much on my side.

PhilippHaefele commented 1 year ago

Thanks for merging. Happy to contribute 😃