search

ottypes / docs

277 stars 29 forks source link

Has this repository been splitted? #17

Closed sheerun closed 10 years ago

sheerun commented 10 years ago

I see that master version of ShareJS is using this repository as dependency, yet it contains no code.

Could you explain in README that it has been split to separate repositories, and which ones?

sheerun commented 10 years ago

Actually even ShareJS 0.8 is still using ottypes repo while livedb (its dependency) is using extracted ot-text ot-text-tp2 ot-json0. Could you explain it? Won't it cause any problems if those dependencies turn out of sync?

josephg commented 10 years ago

:+1: Please add that to the readme and submit a pull request. The npm 'ottypes' package is officially deprecated and it won't be updated unless there's a serious issue - which I doubt, because that code is remarkably well tested and stable. ShareJS 0.8 will depend on the split repositories instead, but I haven't finished refactoring the code for 0.8 yet or figured out how you specify which types you want when you build a sharejs client bundle.

NPM packages don't depend on the repository which contains the code. It doesn't matter that the code isn't here anymore. But if you need it, take a look at the v1.0.2 tag.

As for keeping everything in sync, spec for the individual named types is finalized. Any subsequent changes to ot types will either be backwards compatible or be given new names.