Closed ishbu closed 9 years ago
I did run the tests and they seemed to pass, so not sure whats going on with the Travis CI build.
Updated the tests to add a timeout matching the slow time, because mocha now defaults to 2s resulting in a failed test. Since the randomizers can run at arbitrary length depending on how many tests you want, we need the timeout to be longer.
I compared the time to run 1000 tests with the previous and the difference in completion time is negligible.
Cool, looks good. Good to know about mocha - that might explain some other failing tests I'm seeing all of a sudden.
Thanks! Do you think you publish this to npm as well?
Sure.
sephsmac:json0 josephg$ npm publish && git push && git push --tags
npm http PUT https://registry.npmjs.org/ot-json0
npm http 201 https://registry.npmjs.org/ot-json0
+ ot-json0@1.0.1
We've been seeing a rare occurence issue where elem during json.checkObj in apply is called on an undefined elem.
Still not sure of the root cause of the issue. But I believe this is a better object check that results in the error being thrown properly. Otherwise you get a stack trace like: