oturns / geosnap

The Geospatial Neighborhood Analysis Package
https://oturns.github.io/geosnap-guide
BSD 3-Clause "New" or "Revised" License
247 stars 32 forks source link

(bug) inconsistency of localizing quilt3 data sets #116

Closed weikang9009 closed 5 years ago

weikang9009 commented 5 years ago

In the data module, an Import error is given if several data sets are not stored locally using the function data.store_census. The inspected data sets include blocks_2010 and blocks_2000 which are not localized by function data.store_census.

Thus, even if users called data.store_census before, they will still run into the Import error.

We should resolve this bug by making a choice in terms of whether to localize blocks_2010 and blocks_2000 for general users as they are pretty large.

knaaptime commented 5 years ago

where are you getting an error? as of #111, you should receive a warning that you're using streaming data, if you haven't called the store_census function

I'd intended to provide two additional functions (store_blocks_2000 and store_blocks_2010) since each of those total about 5gb

weikang9009 commented 5 years ago

If you look at the function data.store_census, it is not storing the two large data sets. But the data import is checking on these two data sets.

knaaptime commented 5 years ago

yeah, it should be a different check since store_census shouldn't download blocks

knaaptime commented 5 years ago

resolved by #117