oturns / geosnap

The Geospatial Neighborhood Analysis Package
https://oturns.github.io/geosnap-guide
BSD 3-Clause "New" or "Revised" License
247 stars 32 forks source link

refactor dynamics module #125

Closed weikang9009 closed 5 years ago

weikang9009 commented 5 years ago

This PR is to refactor dynamics module to mimic the cluster/analytics module. Major changes are:

The notebook 04_modeling_neighborhood_dynamics.ipynb is rewritten to demonstrate the usage of the refactored dynamics module.

knaaptime commented 5 years ago

this looks great, nice work. Since we're now depending on Transition and Sequence from the newest giddy, we should also pin that as the minimum compatible version.

I also renamed the notebooks in the last commit (because needed to insert harmonize in the middle), but it looks like maybe the dynamics notebook is still WIP?

weikang9009 commented 5 years ago

this looks great, nice work. Since we're now depending on Transition and Sequence from the newest giddy, we should also pin that as the minimum compatible version.

Set the constraints in https://github.com/spatialucr/geosnap/pull/125/commits/c3be3b049400bcd2640b9f67f3a98fc9039deeb5.

I also renamed the notebooks in the last commit (because needed to insert harmonize in the middle), but it looks like maybe the dynamics notebook is still WIP?

The notebook is ready https://github.com/weikang9009/geosnap/blob/sa/examples/05_modeling_neighborhood_dynamics.ipynb