search

oturns / geosnap

The Geospatial Neighborhood Analysis Package
https://oturns.github.io/geosnap-guide
BSD 3-Clause "New" or "Revised" License
247 stars 32 forks source link

Issue #59 - Inflation Adjustment #157

Closed JennEYoon closed 4 years ago

JennEYoon commented 5 years ago

Ready for your review of PR for Issue #59.

  1. Verified that all ltdb variables that are affected by inflation adjustment are included in inflate_cols and the named strings match data from ltdb column of variables.csv. Function file data/data.py, line 494. I have checked every row of variables.csv file. There are no new variables for inflation adjustment. There are 8 variables that are affected by inflation adjustment.

  2. Copied similar logic from ltdb inflate_cols into "store_ncdb" function definition. Use data from ncdb column in variables.csv. In data/data.py, see lines 678 - 701. Only 3 rows related to inflation adjustment have named strings in ncdb column. I am not sure if this logic works as desired. I added a definition for year, which is used in the last 2 lines.

  3. Corrected several typos in documentation string part of data.py. ("dataframe" and "instantiation")

Thank you! Jennifer Yoon

sjsrey commented 4 years ago

Closing as this is now covered in #216