search

oturns / geosnap

The Geospatial Neighborhood Analysis Package
https://oturns.github.io/geosnap-guide
BSD 3-Clause "New" or "Revised" License
247 stars 32 forks source link

Update notebooks for tsplot documentation #245

Closed AnGWar26 closed 4 years ago

AnGWar26 commented 4 years ago

This adds a notebook detailing the behavior and features in tsplot. We could also replace the time series plotting function used in the other notebooks, 02_creating_community_datasets.ipynb and 04_modeling_neighborhood_types.ipynb with tsplot if you would like.

codecov[bot] commented 4 years ago

Codecov Report

Merging #245 into master will decrease coverage by 18.01%. The diff coverage is 69.23%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master     #245       +/-   ##
===========================================
- Coverage   81.98%   63.96%   -18.02%     
===========================================
  Files          12       12               
  Lines         816      827       +11     
===========================================
- Hits          669      529      -140     
- Misses        147      298      +151
Impacted Files Coverage Δ
geosnap/_community.py 68.26% <33.33%> (-7.52%) :arrow_down:
geosnap/analyze/analytics.py 72.17% <100.00%> (+1.26%) :arrow_up:
geosnap/analyze/dynamics.py 22.58% <0.00%> (-77.42%) :arrow_down:
geosnap/io/storage.py 24.66% <0.00%> (-70.67%) :arrow_down:
geosnap/io/util.py 48.83% <0.00%> (-30.24%) :arrow_down:
geosnap/_data.py 74.11% <0.00%> (+3.52%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 40acb68...cb7d8b5. Read the comment docs.

knaaptime commented 4 years ago

I missed it on the original pr, but i think we should make tsplot a method on the community rather than a function that consumes one

knaaptime commented 4 years ago

shouldnt also save_fig take a path?

AnGWar26 commented 4 years ago

I missed it on the original pr, but i think we should make tsplot a method on the community rather than a function that consumes one

I can put up a PR to reimplement tsplot on the Community class soon to be merged before this PR.

shouldnt also save_fig take a path?

If save_fig is offered no path then it will save in the present working directory. We could create the option of specifying a path: https://matplotlib.org/3.2.1/api/_as_gen/matplotlib.pyplot.savefig.html