search

oturns / geosnap

The Geospatial Neighborhood Analysis Package
https://oturns.github.io/geosnap-guide
BSD 3-Clause "New" or "Revised" License
247 stars 32 forks source link

mapclassify pooling on tsplot #260

Closed AnGWar26 closed 4 years ago

AnGWar26 commented 4 years ago

Would be very useful to have mapclassify pooled classifiers on tsplot.

However, this seems to be on hold, as our plotting solution for tsplot has a bug where we can not retrieve the legend after it's created by the geopandas plotter.

See: https://github.com/lukelbd/proplot/issues/224

knaaptime commented 4 years ago

@AnGWar26 take a look at #265 which allows for pooled classification in the (renamed) plot_timeseries. I think that should resolve this issue, but it doesnt touch the legend at all, so not sure about the proplot issues you're running into

one thing that would be nice to improve on #265 would be to plot a single legend (maybe off to the side) rather than repeating the same one below for each ax

AnGWar26 commented 4 years ago

@knaaptime This seems like a great workaround for the problem that I was having! I'm glad to learn about the classification_kwds parameter in the geopandas plotter, it seems like it's pretty useful.

knaaptime commented 4 years ago

agreed... i also didnt know about missing_kwds which is a nice recent addition. Do you want to keep this issue open while you work on the proplot legend? or should we close with #265 merged?

AnGWar26 commented 4 years ago

It seems like it would be a good idea to close this issue, unless you'd like to move to a different solution for this in the future? I think the improvement you mentioned for #265 where we use a single legend shouldn't be too difficult.

knaaptime commented 4 years ago

ok lets open a separate issue for that