oturns / geosnap

The Geospatial Neighborhood Analysis Package

https://oturns.github.io/geosnap-guide

BSD 3-Clause "New" or "Revised" License

243 stars 32 forks source link

change channel priority to strict #303

Closed AnGWar26 closed 3 years ago

AnGWar26 commented 3 years ago

https://github.com/pysal/segregation/pull/166

I saw that this makes the builds take around 1.5x times longer, but this seems like a good stopgap to get the builds working again before redoing the unit tests to use mamba.

codecov[bot] commented 3 years ago

Codecov Report

Merging #303 (9c31776) into master (3d290e5) will increase coverage by 0.2%. The diff coverage is 100.0%.

@@           Coverage Diff            @@
##           master    #303     +/-   ##
========================================
+ Coverage    68.9%   69.1%   +0.2%     
========================================
  Files          14      14             
  Lines        1193    1195      +2     
========================================
+ Hits          822     826      +4     
+ Misses        371     369      -2

Impacted Files	Coverage Δ
geosnap/_community.py	`73.0% <100.0%> (+0.1%)`	:arrow_up:
geosnap/analyze/analytics.py	`85.9% <0.0%> (+1.0%)`	:arrow_up:

knaaptime commented 3 years ago

@jgaboardi any chance i can talk you into taking a look at our CI setup wrt the efficiency gains you just added elsewhere?

jGaboardi commented 3 years ago

@jGaboardi any chance i can talk you into taking a look at our CI setup wrt the efficiency gains you just added elsewhere?

Absolutely. I'll put it on my to-do.

knaaptime commented 3 years ago

i think this is superseded by #304, so going to close. Feel free to reopen if i'm incorrect

knaaptime commented 3 years ago

i think we still need the mpl pin from this PR