oturns / geosnap

The Geospatial Neighborhood Analysis Package

https://oturns.github.io/geosnap-guide

BSD 3-Clause "New" or "Revised" License

243 stars 32 forks source link

inflation table missing from conda package #321

Closed knaaptime closed 2 years ago

knaaptime commented 2 years ago

something weird is going on with the anaconda releases. We have a file inside the package that stores inflation weights. On the pypi release, that file is included in the tarball, but in the anaconda release the file is excluded. I cant figure out why 🤷‍♂️

knaaptime commented 2 years ago

nope. still an issue. I have no idea how to solve this. The pip version is complete; the conda version is broken because bls.csv is missing

knaaptime commented 2 years ago

322 partially addresses this by providing a fallback to the online version of the file, but it doesn't solve the root issue that the file is omitted during the conda-forge package build

sjsrey commented 2 years ago

Using geosnap 0.8.2, if the inflator is required (i.e., creating a community), there is a traceback about a missing dep:

ImportError: Missing optional dependency 'openpyxl'.  Use pip or conda to install openpyxl.

Installing that and restarting raises

HTTPError: HTTP Error 403: Forbidden

when trying to access the bls data.

I'm wondering if it would be worth adding the inflator series inside the adjust_inflation function rather than having to hit bls?

sjsrey commented 2 years ago

It could be that:

https://github.com/spatialucr/geosnap/blob/master/setup.py#L78

needs to be updated to bring io/bls_inflation.parquet along for the ride?

knaaptime commented 2 years ago

resolved by #324