oturns / geosnap

The Geospatial Neighborhood Analysis Package
https://oturns.github.io/geosnap-guide
BSD 3-Clause "New" or "Revised" License
241 stars 32 forks source link

refactor sim code #367

Closed knaaptime closed 11 months ago

knaaptime commented 1 year ago
knaaptime commented 1 year ago

@sjsrey @weikang9009 @ljwolf this PR refactors the code for drawing states from the SMC to generalize and make more transparent. If you're into it, it might be an opportune time to move some over into giddy to address https://github.com/pysal/giddy/issues/161

one or two pieces can still be parallelized (left comments where) and the seeding still isnt working perfectly. I think the mechanics are right, but i cant generate reproducible results reliably. Might have something to with the tolerance/rounding coming out of the SMC

knaaptime commented 11 months ago

also addresses #368