oturns / geosnap

The Geospatial Neighborhood Analysis Package
https://oturns.github.io/geosnap-guide
BSD 3-Clause "New" or "Revised" License
241 stars 32 forks source link

Depending on abandoned scikitplot #394

Closed martinfleis closed 6 months ago

martinfleis commented 7 months ago

Hey,

In libpysal reverse dependency checks, geosnap is failing because scikitplot is trying to import some deprecated stuff from scipy as reported in https://github.com/reiinakano/scikit-plot/issues/119. (see the log). I checked https://github.com/reiinakano/scikit-plot and it seems well abandoned. I am curious if it is wise to depend on it given it currently breaks the import of geosnap in latest env.

knaaptime commented 7 months ago

good call. the tests started failing over the weekend from that deprecation. Probably should toss it