oturns / geosnap

The Geospatial Neighborhood Analysis Package
https://oturns.github.io/geosnap-guide
BSD 3-Clause "New" or "Revised" License
247 stars 32 forks source link

Reading LTBD data - inconsistent paths for full count and sample files? #61

Closed weikang9009 closed 5 years ago

weikang9009 commented 5 years ago

Not sure why the relative path of LTDB full count file is different from the sample file?

For instance, the path to the full count 1980 is "LTDB_Std_1980_fullcount.csv":

    fullcount80 = _ltdb_reader(
        fullcount_zip, "LTDB_Std_1980_fullcount.csv", year=1980)

while the path for the sample file lives in another folder "ltdb_std_all_sample/ltdb_std_1980_sample.csv":

    sample80 = _ltdb_reader(
        sample_zip,
        "ltdb_std_all_sample/ltdb_std_1980_sample.csv",
        dropcols=["pop80sf3", "pop80sf4", "hu80sp", "ohu80sp"],
        year=1980,
    )

It makes more sense to adopt either form to keep consistency.

knaaptime commented 5 years ago

its not us, that is the way the folks at Brown packaged the zip files

knaaptime commented 5 years ago

the fullcount files are in the root of the zip, the sampled files are within a folder that sits at the root of the zip, so this is unavoidable