search

oturns / geosnap

The Geospatial Neighborhood Analysis Package
https://oturns.github.io/geosnap-guide
BSD 3-Clause "New" or "Revised" License
244 stars 32 forks source link

error related quilt upgrade to 3.0 #85

Closed suhanmappingideas closed 5 years ago

suhanmappingideas commented 5 years ago

I tried to install geosnap in the clean environment on 05/28/2019. When I imported geosnap, it gave me an error below (I didn't get the same error a few months ago)

image

The issue was quilt package has changed from 2.9.15 to 3.0.0 on 2019/05/25 (major change)

Here is the difference: image

The error above has been resovled by running the command line below after I activated geosnap environment after yml installation. image

I think that we need to set quilt version to 2.9.15 in environment.yml or revise source in geosnap.data based on the quilt 3.0.0.

knaaptime commented 5 years ago

thanks for this--and for pointing to the migration doc! I'll update to use the new syntax

knaaptime commented 5 years ago

actually, could you also share the link to that doc?

suhanmappingideas commented 5 years ago

I collected the info from a few different websites. For quilt 2: https://docs.quiltdata.com/v/quilt-2-master/api/api-python

For quilt 3: https://docs.quiltdata.com/walkthrough/distributing-a-package https://docs.quiltdata.com/walkthrough/installing-a-package

knaaptime commented 5 years ago

oh, you put this graphic together yourself! super helpful, thank you.

knaaptime commented 5 years ago

strange... it looks like maybe the 3.0 release was rolled back https://pypi.org/project/quilt/#history

As an alternative, we could avoid this issue by not installing these data packages in the code. Instead, we make users install our quilt packages explicitly and raise an informative warning if a package is missing (rather than trying to install it automatically). That would avoid breakage from changes to quilt's API, and i've been thinking about refactoring that way for awhile because it's more pythonic anyway

knaaptime commented 5 years ago

got it. they rolled back and released the new version as t4

i'm working with their team to get a conda-forge recipe put together, so once it is available we'll move from quilt to t4 and this will be resolved

knaaptime commented 5 years ago

this is resolved by #97

weikang9009 commented 5 years ago

I ran into the following error after pulling the most recent version of geosnap from github image Not sure why, maybe I am missing some packages?

knaaptime commented 5 years ago

sorry, that one got past me. should be fixed now

weikang9009 commented 5 years ago

Thanks!

On Fri, Aug 2, 2019 at 4:59 PM eli knaap notifications@github.com wrote:

sorry, that one got past me. should be fixed now

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/spatialucr/geosnap/issues/85?email_source=notifications&email_token=ABYEWNARUBN7SPUFNV74ZC3QCTC7PA5CNFSM4HQFQTJ2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD3PCNEY#issuecomment-517875347, or mute the thread https://github.com/notifications/unsubscribe-auth/ABYEWNBNITT7MVJOJBFCQJLQCTC7PANCNFSM4HQFQTJQ .

-- Wei Kang Postdoctoral Scholar Center for Geospatial Sciences University of California, Riverside Personal Website https://weikang9009.github.io/