search

oturns / geosnap

The Geospatial Neighborhood Analysis Package
https://oturns.github.io/geosnap-guide
BSD 3-Clause "New" or "Revised" License
247 stars 32 forks source link

consider pysal submodule #93

Closed knaaptime closed 5 years ago

knaaptime commented 5 years ago

we want to ensure consistency with the way the constituent pysal libs are imported and used throughout the package (e.g. mixing metapackage and individual libs) one way to handle that is to creata a submodule that handles all the pysal imports in one shot (which are then propagated through)

knaaptime commented 5 years ago

the purpose and logic here make sense, but i would prefer to enforce a policy that we strictly use the submodules (could be checked on each code review/PR).

knaaptime commented 5 years ago

we also dont have a pysal dependency, so hopefully a this would be an easy catch during a PR.

closing as I think we're generally in favor of this strategy, but please reopen if you disagree