search

otwld / ollama-helm

Helm chart for Ollama on Kubernetes
https://artifacthub.io/packages/helm/ollama-helm/ollama
MIT License
216 stars 36 forks source link

fix: models must be a list not a map #52

Closed shiipou closed 3 months ago

shiipou commented 3 months ago

As I understand, in values.yml, the ollama.models must be a list not a map.

So we can't set any values to it in the current state of the project.

ntrehout commented 3 months ago

Hey @shiipou,

Thank you for pointing that out! Even though it’s clarified in the comments that it should be a list, the empty initialization is indeed incorrect. It should be [] instead of {}. Thanks for bringing this to our attention!

So we can't set any values to it in the current state of the project. - I'm not sure what you mean by that, because if you follow the comments it should work fine.

shiipou commented 3 months ago

Hey @shiipou,

Thank you for pointing that out! Even though it’s clarified in the comments that it should be a list, the empty initialization is indeed incorrect. It should be [] instead of {}. Thanks for bringing this to our attention!

So we can't set any values to it in the current state of the project. - I'm not sure what you mean by that, because if you follow the comments it should work fine.

When I apply the values.yml like the readme.md said, that tell me that I can't merge a map with a list.