otwstephanie / otwarchive3

Clone of OTWarchive, for merge testing
0 stars 0 forks source link

TABLES not validated #320

Closed otwstephanie closed 10 years ago

otwstephanie commented 10 years ago

From liminim...@googlemail.com on September 08, 2008 08:56:01

rev 597 I've mostly marked up the tables but they need checking. They need a dedicated table wrangler. They eriously need someone to go through and add captions. I've commented the caption tags with what is needed.

==TABLES==

< http://wiki.transformativeworks.org/mediawiki/Coding_Standards:_XHTML/CSS#Tables > < http://www.w3.org/TR/html401/struct/tables.html > < http://www.456bereastreet.com/archive/200410/bring_on_the_tables/ >

1) Tables may only be used to display tabular data. All tables must at minimum have a , headers , and scopes

A caption summarising the contents and purpose of table
HEADING HEADING
ENTRY TITLE DATA

Original issue: http://code.google.com/p/otwarchive/issues/detail?id=320

otwstephanie commented 10 years ago

From Black0Sa...@gmail.com on September 09, 2008 06:11:54

Labels: Roadmap-MainNavigation

otwstephanie commented 10 years ago

From eni...@gmail.com on March 06, 2009 13:11:38

Labels: Milestone-Release1.0

otwstephanie commented 10 years ago

From cesy.a...@gmail.com on December 15, 2009 03:41:47

Labels: Component-FrontEnd

otwstephanie commented 10 years ago

From liminim...@googlemail.com on January 22, 2010 09:49:14

taking ownership of these issues until jan 30 for administration purposes

Owner: liminimail

otwstephanie commented 10 years ago

From liminim...@googlemail.com on January 30, 2010 10:42:57

This issue was updated by revision r2119 .

Validated partials. Added summaries and captions to many tables, legends and fieldsets to many forms. Still more to do in the big review (not by me). fixes issue 776 fixes issue 848 2. Redeclared all classes to meet coding standards. classes listed in <kekkai.org/lim/goodies/Front End Help/classes.html>

  1. update issue 1172 status: Accepted Added WAI-ARIA Landmark roles to main document regions: banner, search, main, navigation, contentinfo (footer), complementary, article. This is a first pass to give a general idea. Should be looked at when Navigation is reviewed.
  2. Added .landmark class headings to main document regions to give a broad structure. Enforced document flow as per
  3. Removed stylesheets layout-elements.css, story-views.css, tags.css, comments.css - moved tags styling into chrome but left otherwise as legacy styles in prep for meta tags.
  4. Added stylesheets site-chrome.css and user-generated-views.css as per discussion in otw-coders and frontend list
  5. Added class .user-generated-view to every element containing content inputted by a user into a textarea that allows html to pick up all styling/cascade errors reported by users where the site chrome layout was applying to their works (no bullets on lists etc). Also /help and /tos body copy.

fixes issue 616 fixes issue 966 fixes issue 1060 fixes issue 1134 fixes issue 1188 fixes issue 1269 8. Regularised many structures: particularly note: pseuds switcher, inbox, comments, bookmarks, navigation throughout (commented BACK END where backend needs to relogic)

fixes issue 864 fixes issue 1090 fixes issue 1228 fixes issue 1271 9. Reordered the blurbs so the title comes first for screenreaders

  1. CSS: compressed and streamlined css - rewrote most everything except Post New fixes issue 1066 fixes issue 1155 fixes issue 1181 11. Added custom fonts for Internet Explorer

fixes issue 1142 12. Optimised for IE 6, IE7, IE8 - need a tester to bang on it

fixes issue 757 fixes issue 761 fixes issue 772 fixes issue 771 fixes issue 795 fixes issue 814 fixes issue 889 fixes issue 891 fixes issue 1026 fixes issue 1077 fixes issue 1079 fixes issue 1084 fixes issue 1257 reject issue 804 --trivial reject issue 892 --not worth the code reject issue 1071 --not worth the code

  1. Picked up myriad cascade errors and UX slips - dashboard current tab is now black, hover on banner link is now white, tag styling gone off non-tag links etc etc

New issue: Screenreader List Counting Labels: Accessibility UI Picked up count errors - now all lists count the actual number of items in the list or have a count announcing the list - please can a tester get fangs or firevox and check this on the indices.

  1. Chucked button and field border/outline/background styling on forms (but not widths), styled them up like navigation and other action buttons - kick it back to ADT as part of navigation review. Floated all actions so be aware of clearing.

fixes issue 789 Update issue 319 Recommendation for forms recorded here:

  1. Marked up each page with consistent order and commented the regions so back end know where to put things. template at
  2. Semantics - made sortable lists
      , block quotes
      etc etc.
    1. New issue Summary: landmark and role added to pagination Status: Accepted
      Labels:Component:UI Type-Enhancement Need to add .landmark and role to pagination. must not print pagination h3 landmark to page where there is no pagination!
    2. New issue Summary: v0.1 handheld stylesheet Status: Accepted
      Labels:Component:FrontEnd +Type-Enhancement added v0.1 handheld stylesheet - suppressed custom font, made body larger font, linearised blurbs and meta but cannot test at all- next stage for mobiles is prolly moving the icons off page load
    3. moved filters below main content
    4. blocked off that funny jiggle on the character counters fixes issue 1195 22. rejigged print - upped the leading, restyled the blurbs so they are clean printable lists, fixed the attribute insertion
    5. enigel fixes issue 1255 24. fixes issue 1270 25. rewrote first-login-help to remove sighted bias and mousing bias as well as inline css and validation.
    6. fixes issue 1230 27. restyled tables a little - gave them Fertigo headers and lightened the backgrounds to follow the lighter greys throughout - this is 1-2 lines of codes and can easily be reverted
    7. IMPORTANT, FRONT END - i moved the negative margins from the ul onto the dd in all the .metas, which means if we get a double dd structure it will need tweaking.
    8. put in a presentational/grouping .wrapper class with a drop-shadow applied to it. it can be called and wrapped round any block - see metas, dynamic comment/bookmark/collection for examples fixes issue 783 30. knocked all the headers down one step in the em scale - h2 now 24 from 36, and combined the page title and search query - BACK END pls tart up wordage there - it's tad awkward

    New Issue: Gzip Fonts and CSS Status:Accepted Labels: Performance Type: Enhancement Please, Systems, Gzip the fonts and CSS files. I have failed to do this because my brain is made of jam.

    Status: Accepted

otwstephanie commented 10 years ago

From liminim...@googlemail.com on January 30, 2010 10:45:34

This issue was updated by revision r2120 .

Validated partials. Added summaries and captions to many tables, legends and fieldsets to many forms. Still more to do in the big review (not by me). fixes issue 776 fixes issue 848 2. Redeclared all classes to meet coding standards. classes listed in <kekkai.org/lim/goodies/Front End Help/classes.html>

  1. update issue 1172 status: Accepted Added WAI-ARIA Landmark roles to main document regions: banner, search, main, navigation, contentinfo (footer), complementary, article. This is a first pass to give a general idea. Should be looked at when Navigation is reviewed.
  2. Added .landmark class headings to main document regions to give a broad structure. Enforced document flow as per
  3. Removed stylesheets layout-elements.css, story-views.css, tags.css, comments.css - moved tags styling into chrome but left otherwise as legacy styles in prep for meta tags.
  4. Added stylesheets site-chrome.css and user-generated-views.css as per discussion in otw-coders and frontend list
  5. Added class .user-generated-view to every element containing content inputted by a user into a textarea that allows html to pick up all styling/cascade errors reported by users where the site chrome layout was applying to their works (no bullets on lists etc). Also /help and /tos body copy.

fixes issue 616 fixes issue 966 fixes issue 1060 fixes issue 1134 fixes issue 1188 fixes issue 1269 8. Regularised many structures: particularly note: pseuds switcher, inbox, comments, bookmarks, navigation throughout (commented BACK END where backend needs to relogic)

fixes issue 864 fixes issue 1090 fixes issue 1228 fixes issue 1271 9. Reordered the blurbs so the title comes first for screenreaders

  1. CSS: compressed and streamlined css - rewrote most everything except Post New fixes issue 1066 fixes issue 1155 fixes issue 1181 11. Added custom fonts for Internet Explorer

fixes issue 1142 12. Optimised for IE 6, IE7, IE8 - need a tester to bang on it

fixes issue 757 fixes issue 761 fixes issue 772 fixes issue 771 fixes issue 795 fixes issue 814 fixes issue 889 fixes issue 891 fixes issue 1026 fixes issue 1077 fixes issue 1079 fixes issue 1084 fixes issue 1257 reject issue 804 --trivial reject issue 892 --not worth the code reject issue 1071 --not worth the code

  1. Picked up myriad cascade errors and UX slips - dashboard current tab is now black, hover on banner link is now white, tag styling gone off non-tag links etc etc

New issue: Screenreader List Counting Labels: Accessibility UI Picked up count errors - now all lists count the actual number of items in the list or have a count announcing the list - please can a tester get fangs or firevox and check this on the indices.

  1. Chucked button and field border/outline/background styling on forms (but not widths), styled them up like navigation and other action buttons - kick it back to ADT as part of navigation review. Floated all actions so be aware of clearing.

fixes issue 789 Update issue 319 Recommendation for forms recorded here:

  1. Marked up each page with consistent order and commented the regions so back end know where to put things. template at
  2. Semantics - made sortable lists
      , block quotes
      etc etc.
    1. New issue Summary: landmark and role added to pagination Status: Accepted
      Labels:Component:UI Type-Enhancement Need to add .landmark and role to pagination. must not print pagination h3 landmark to page where there is no pagination!
    2. New issue Summary: v0.1 handheld stylesheet Status: Accepted
      Labels:Component:FrontEnd +Type-Enhancement added v0.1 handheld stylesheet - suppressed custom font, made body larger font, linearised blurbs and meta but cannot test at all- next stage for mobiles is prolly moving the icons off page load
    3. moved filters below main content
    4. blocked off that funny jiggle on the character counters fixes issue 1195 22. rejigged print - upped the leading, restyled the blurbs so they are clean printable lists, fixed the attribute insertion
    5. enigel fixes issue 1255 24. fixes issue 1270 25. rewrote first-login-help to remove sighted bias and mousing bias as well as inline css and validation.
    6. fixes issue 1230 27. restyled tables a little - gave them Fertigo headers and lightened the backgrounds to follow the lighter greys throughout - this is 1-2 lines of codes and can easily be reverted
    7. IMPORTANT, FRONT END - i moved the negative margins from the ul onto the dd in all the .metas, which means if we get a double dd structure it will need tweaking.
    8. put in a presentational/grouping .wrapper class with a drop-shadow applied to it. it can be called and wrapped round any block - see metas, dynamic comment/bookmark/collection for examples fixes issue 783 30. knocked all the headers down one step in the em scale - h2 now 24 from 36, and combined the page title and search query - BACK END pls tart up wordage there - it's tad awkward

    New Issue: Gzip Fonts and CSS Status:Accepted Labels: Performance Type: Enhancement Please, Systems, Gzip the fonts and CSS files. I have failed to do this because my brain is made of jam.

otwstephanie commented 10 years ago

From liminim...@googlemail.com on January 31, 2010 04:03:17

please ignore my giant mad comments above! error! error!

this is a constant gardening task at the moment tables are mostly complete but a lot are missing summaries

otwstephanie commented 10 years ago

From eni...@gmail.com on February 28, 2010 09:40:40

Labels: -Component-UI

otwstephanie commented 10 years ago

From eni...@gmail.com on April 03, 2010 05:15:18

Housekeeping: issues with owners -> Assigned

Status: Assigned

otwstephanie commented 10 years ago

From liminim...@googlemail.com on April 14, 2010 13:29:11

Status: Accepted
Owner: ---

otwstephanie commented 10 years ago

From autu...@gmail.com on November 14, 2010 11:54:53

Bulk adding NeedsTest labels to all open issues

Labels: NeedsTests

otwstephanie commented 10 years ago

From sarken on July 14, 2012 01:03:58

Status: Started
Owner: sarken

otwstephanie commented 10 years ago

From sarken on July 17, 2012 00:34:25

https://github.com/otwcode/otwarchive/pull/756 Tables needed scopes, captions, and summaries, and, in some cases, they needed to no longer be tables. I full acknowledge that this strayed from the original issue quite a bit: these pages were missing translation strings, and the admin pages needed some general clean-up in order to look consistent and allow admin-specific CSS tweaks.

Tables removed from:

Containing div class="admin" added to:

Some pages needed an actions class removed from a submit button to keep it from floating outside the table form:

Some tables needed the stats class removed in order to display the cells beneath the headers:

Inline styles removed from:

Some table forms had their submit buttons in incorrectly-placed tfoots (they should have been after thead and before tbody) and were moved to match the majority of table forms, where the button comes after the table:

Notes:

Status: SubmittedPullRequest

otwstephanie commented 10 years ago

From eni...@gmail.com on August 09, 2012 03:56:42

https://github.com/otwcode/otwarchive/commit/0765c710b129894117fd0c5f1988ee7b1b4ac78b

Status: FixedAndCommitted

otwstephanie commented 10 years ago

From eni...@gmail.com on August 10, 2012 19:45:05

Status: DeployedToTest
Labels: Release-0.9.0

otwstephanie commented 10 years ago

From sarken on August 26, 2012 01:32:54

I should note that, despite all this, the tables aren't actually going to validate using the W3C XHTML validator, since they're coded to standards closer to HTML5. The important things here are really that:

  1. The tables (or replacements for tables) display properly
  2. The tables have tags
  3. Any tags have scope attributes
otwstephanie commented 10 years ago

From jenn.cal...@googlemail.com on August 27, 2012 08:07:41

ff14: pages displaying properly: http://testarchive.transformativeworks.org/abuse_reports http://testarchive.transformativeworks.org/abuse_reports/1 http://testarchive.transformativeworks.org/admin/users http://testarchive.transformativeworks.org/admin/users?utf8=%E2%9C%93&query=&role=tag_wrangler&commit=Find (results of a search for users) http://testarchive.transformativeworks.org/admin/users/testy http://testarchive.transformativeworks.org/admin/users/notify http://testarchive.transformativeworks.org/admin/invitations http://testarchive.transformativeworks.org/admin/invitations/find?utf8=%E2%9C%93&user_name=testy&token=&invitee_email=&commit=Go http://testarchive.transformativeworks.org/admin_posts http://testarchive.transformativeworks.org/archive_faqs http://testarchive.transformativeworks.org/admin/settings http://testarchive.transformativeworks.org/admin/skins http://testarchive.transformativeworks.org/user_invite_requests -- can't check this properly as there are no requests on test and none can be created. http://testarchive.transformativeworks.org/admin/skins/index_approved -- the columns aren't lined up (idk if this is a real problem or not)

I am not sure if that is all the pages, as I really don't understand this issue. I haven't looked through the source code. It would be really helpful for more info about which pages are effected

otwstephanie commented 10 years ago

From sarken on August 27, 2012 16:58:15

Unless otherwise noted, you need to be logged in as an admin. You can use this skin to reveal the caption (it'll be a title on a yellow background) and show table headers that are scoped to rows (pink background) and table headers that are scoped to columns (orange background): http://testarchive.transformativeworks.org/skins/2847 Basically, scoping a thing means 'this cell is like a label for this row or column' so usually the topmost row will be scoped to a column and the leftmost column will be scoped to a row.

I also added summaries to the tables, but there's no way to make those visible, since summary is just an attribute. You can view the source and read the summaries or use a screen reader.

Tables removed from:

Inside the #main div, another div with class="admin" was added to:

Inline styles removed from:

Some table forms had their submit buttons in incorrectly-placed tfoots (they should have been after thead and before tbody) and were moved to match the majority of table forms, where the button comes after the table:

Other tables:

You'll need to be logged in as a user to see the tables on:

I missed:

otwstephanie commented 10 years ago

From jenn.cal...@googlemail.com on August 28, 2012 14:14:19

Checked summaries and scoping on: http://testarchive.transformativeworks.org/abuse_reports http://testarchive.transformativeworks.org/admin/skins http://test.ao3.org/abuse_reports/show : page does not exist and now I can't work out which page it is referring to. http://testarchive.transformativeworks.org/abuse_reports/1 seems to be the only other abuse page and it does not appear to be formatted as a table.

(more tomorrow, hopefully, but I want to submit this comment before I forgot or lose the work)

otwstephanie commented 10 years ago

From sarken on August 28, 2012 14:48:52

http://testarchive.transformativeworks.org/abuse_reports/1 is abuse_reports/show -- sorry. I had the link right one place (Tables removed from) but not the other (Inside the #main div, another div with class="admin" was added to).

otwstephanie commented 10 years ago

From jenn.cal...@googlemail.com on September 01, 2012 13:03:23

Checked: http://testarchive.transformativeworks.org/tag_wranglers/Jenn_Calaelen http://testarchive.transformativeworks.org/tag_wranglings/discuss http://testarchive.transformativeworks.org/tag_wranglings?show=characters etc http://testarchive.transformativeworks.org/tags/Star%20Trek:%20The%20Original%20Series/wrangle?show=characters all fine \o/ ff15 on win7

Does http://testarchive.transformativeworks.org/unsorted_tags want a new issue?

otwstephanie commented 10 years ago

From jenn.cal...@googlemail.com on September 01, 2012 13:15:39

http://testarchive.transformativeworks.org/admins : is the screenshot what this page is supposed to look like? all the links seem to lead to blank pages, but that might be totally unrelated to this issue...

Attachment: testadmins.png

otwstephanie commented 10 years ago

From sarken on September 01, 2012 13:22:15

The admin table is right. I don't understand it, but, yeah, that's how it looks.

I can actually fix the unsorted tags really quick. Stand by for pull request...

otwstephanie commented 10 years ago

From sarken on September 01, 2012 13:48:22

https://github.com/otwcode/otwarchive/pull/829

Status: SubmittedPullRequest

otwstephanie commented 10 years ago

From eni...@gmail.com on September 01, 2012 15:17:10

https://github.com/otwcode/otwarchive/commit/66f7a02787769b3128bf4d9c4e12f318b3cb7f18

Status: FixedAndCommitted

otwstephanie commented 10 years ago

From elz...@gmail.com on September 02, 2012 13:24:11

Status: DeployedToTest

otwstephanie commented 10 years ago

From jenn.cal...@googlemail.com on September 02, 2012 15:01:10

http://testarchive.transformativeworks.org/user_invite_requests looks okay, but hard to tell as there aren't any requests or ways to make requests on test atm http://testarchive.transformativeworks.org/translators looks okay, but no content on test atm http://testarchive.transformativeworks.org/admin/skins/index_rejected ditto

Checked: http://testarchive.transformativeworks.org/translators/new http://testarchive.transformativeworks.org/admin/stats?model=invitations http://testarchive.transformativeworks.org/admin/stats?model=users http://testarchive.transformativeworks.org/admin/stats?model=works http://testarchive.transformativeworks.org/admin/skins/index_approved http://testarchive.transformativeworks.org/admin/skins http://testarchive.transformativeworks.org/admin/users/testy http://testarchive.transformativeworks.org/archive_faqs does not appear to be a table, but looks okay http://testarchive.transformativeworks.org/admin/users/notify ditto

I think I've looked at all of these now...

otwstephanie commented 10 years ago

From sarken on September 02, 2012 16:35:30

Tables were removed from http://testarchive.transformativeworks.org/archive_faqs and http://testarchive.transformativeworks.org/admin/users/notify (and http://test.ao3.org/abuse_reports/1 ) per comment 18, so that's right.

otwstephanie commented 10 years ago

From jenn.cal...@googlemail.com on September 03, 2012 04:53:22

Status: VerifiedOnTest

otwstephanie commented 10 years ago

From elz...@gmail.com on September 03, 2012 05:49:43

Status: DeployedToBeta