Pirates! Gold: broken colors throughout the game

otya128 / winevdm

16-bit Windows (Windows 1.x, 2.x, 3.0, 3.1, etc.) on 64-bit Windows

GNU General Public License v2.0

2.67k stars 152 forks source link

Pirates! Gold: broken colors throughout the game #638

Open angrylion7 opened 4 years ago

angrylion7 commented 4 years ago

Latest winevdm, Windows 7, no HAXM. The colors are alright under Windows XP's WoW. Some other 256-color games run fine with winevdm, so it must be application-specific. trace.txt attached.

pirates

pirates.zip

cracyc commented 4 years ago

This uses AnimatePalette in a way that's very difficult to handle in 24bit color mode. Windows builtin 256 color compatibility mode fails with it too. Probably CreateBitmap and CreateCompatibleBitmap would both have to be changed to use dib sections so that the modified palette can be applied before blting to the window dc.

Anixx commented 4 years ago

Would be very interesting to see this fixed.

alexceltare2 commented 4 years ago

You might want to have a look at this: https://www.pcgamingwiki.com/wiki/Rainbow_color_problems_in_older_games

Anixx commented 4 years ago

This happens under Win8.1 as well, and with no Explorer running. I am sure this game does not use DirectDraw.

So, it is irrelevant.

Anixx commented 1 year ago

Still broken...