ouchadam / small-talk

Minimal Android messenger powered by Matrix
Apache License 2.0
141 stars 3 forks source link

Modified messages displayed out of their original order #240

Closed mi5o closed 2 years ago

mi5o commented 2 years ago

Modified messages appear (almost) correctly modified, but out of their original order.

Steps to reproduce:

  1. send message 1
  2. send message 2
  3. send message 3
  4. modify message 2 to message 2+

Expected result:

Message 1 [HH:MM] Message 2+ [edited HH:MM] Message 3 [HH:MM]

Actual result:

Message 1 [HH:MM] Message 3 [HH:MM] * Message2+ [edited HH:MM]

Also note the redundant asterisk at the beginning of the modified message – it already clearly indicates it has been modified.

(seen in foss-signed-31.10.2022-V1.apk running in LineageOS)

ouchadam commented 2 years ago

can confirm :+1: seems to happen when editing your own messages from another client, when others edit their messages it's working as expected (at least for me!)

ouchadam commented 2 years ago

fixed by https://github.com/ouchadam/small-talk/pull/246 (the asterisk has also been removed in recent commits)

mi5o commented 2 years ago

seems to happen when editing your own messages from another client,

I have not seen the fix yet, so maybe it works as expected. But I am going to challenge your description of the cause.

I did everything at one device, in one app (Matrix for Android), in one chat room, as one user, immediately one step after another, editing my own messages in one client.

ouchadam commented 2 years ago

ah when checking messages from others I may have originally only been trying to edit the latest message, the fix from above will cover both cases