search

ouest / asdf-perl

Perl plugin for the asdf version manager
MIT License
29 stars 6 forks source link

Use perl-install rather than Perl-Build, which requires a system perl #8

Closed merrilymeredith closed 2 years ago

merrilymeredith commented 2 years ago

Hi, I actually have a few changes in here and wasn't sure if i should bother opening a separate small PRs or just one to begin the conversation.

The major change here is replacing Perl-Build with https://github.com/skaji/perl-install which does not require a system perl to operate. Both are plenv plugins so it's almost a drop-in change. I also removed plenv because it is not used or required.

I switched to perl-install because MacOS has deprecated its bundled scripting languages, and plans to remove them eventually. This also makes asdf-perl available to minimal environments, like docker images.

The other two changes here are using git itself to track the last update time, rather than a separate file, and only making a shallow clone, which avoids pulling unnecessary data during clone and later updates. I have not added anything that cleans up old plenv directories - I wasn't sure it would be a good idea do that automatically.

ouest commented 2 years ago

Sorry for the late response. Special Thanks for this p-r.

I confirmed that the changes and behavior are fine, so merged.