search

oughtinc / patchwork

Command-line recursive question-answering with immutable contexts and explicit data store
https://ought.org/projects/factored-cognition
MIT License
24 stars 1 forks source link

Clean-up: Avoid constructing Contexts with args[0], db, args[1], … #14

Open rmoehn opened 6 years ago

rmoehn commented 6 years ago

There are several places in the code where a Context is constructed from datastore contents like this:

        all_successors = [Context(args[0], db, args[1], parent=args[2])
                for args in answer_successors + workspace_successors]

Replace these with something more readable.

This includes the args[0] in the procedure _can_advance_promise in context.py.

rmoehn commented 6 years ago

The same goes for hypertext.Subquestion. Make it a namedtuple or a Python 3.7 dataclass.

rmoehn commented 6 years ago

The construction of Workspaces is similarly repetitive.