oughtinc / patchwork

Command-line recursive question-answering with immutable contexts and explicit data store
https://ought.org/projects/factored-cognition
MIT License
24 stars 1 forks source link

Add test for issue #4 #5

Closed rmoehn closed 6 years ago

rmoehn commented 6 years ago

This test exposes the failure described in issue #4. It might turn out to be too silent for comfortable debugging, but we can add logging and test set-up helpers later as needed.

Of course, @benwr is much more familiar with the code than me, so he might be able to find out what is going on without much digging.

benwr commented 6 years ago

I strongly appreciate this PR; to be honest the way that sessions work is pretty hacky (the name "patchwork" is not an accident); I may try to clean up some of it starting on Sunday, but I'm not certain I'll have time to do so until the end of the week.

rmoehn commented 6 years ago

Don't worry, I'm not depending on it. Just helping out. Let me know if there's anything I can do to help besides tracking down bugs or doing stuff that I think might be useful.