search

ouisharelabs / ouishare_labs_home

OuiShare Labs Home
http://labs.ouishare.net
GNU General Public License v2.0
1 stars 0 forks source link

enable Mozilla Persona #1

Closed elf-pavlik closed 10 years ago

elf-pavlik commented 10 years ago

https://drupal.org/project/persona

Already works very smooth on: http://edgeryders.eu/user/login @kirilind can help with it and maybe @guaka can help with making sure it gets into this git repo (features module, drush make, i_dont_know_drupal :cry: )

darrenmothersele commented 10 years ago

I'll add this upstream in the Kendra Home repo.

darrenmothersele commented 10 years ago

merged here: https://github.com/ouisharelabs/kendra_home/pull/5

darrenmothersele commented 10 years ago

Module added, needs enabling and configuring by a site admin.

kirilind commented 10 years ago

I enabled and configured it some; but due to the previous settings it still requires manual admin acceptance AND additional e-mail validation (due to this setting: "Require e-mail verification when a visitor creates an account." under Conf > People > Account settings). I would get rid of those requirements, but would it make the site vulnerable to spam accounts?

How to proceed? Should we use Persona as the only login option?

Also, I didn't yet touch settings.php. It is currently named default.settings.php (under sites/default), can anybody comment whether I should rather make a copy of this or rename it as settings.php ?

darrenmothersele commented 10 years ago

I can't comment on the account settings, but the settings.php file is generated by the environment (i.e. contains database, redis settings etc), so is not stored in the repo.

kirilind commented 10 years ago

So if I just created it as a copy of default in the repo, what happens now? Nothing, obviously? :-)

The settings should probably define persona audience, until then Admin > Reports complains:

Persona audience http://labs.ouishare.net:80 (determined insecurely) $conf['persona_audience'] must be defined in settings.php. See https://developer.mozilla.org/en-US/docs/Persona/Security_Considerations.

darrenmothersele commented 10 years ago

you shouldn't be able to create a copy of the default settings in the repo, because it's prevented by the .gitignore file. this is a security thing - sensitive information is stored in settings.php. the file is actually created by the build system. So the settings needs adding to the environment. Can you email Daniel the name of the setting and the value? Then we can add it to the environment config.

kirilind commented 10 years ago

Well, I just did: https://github.com/ouisharelabs/kendra_home/blob/master/sites/default/settings.php. I understand it won't copy over probably because of the chmod of the real settings file so i can delete it again. Will email Daniel.

darrenmothersele commented 10 years ago

I added support for that setting to the build script and added it to the manifest for the site, so should be there now.