search

oulan / iui

Automatically exported from code.google.com/p/iui
MIT License
0 stars 0 forks source link

dialog "overlay" should cover all body height. #299

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
What steps will reproduce the problem?
launching a dialog

What is the expected output? What do you see instead?
dialog overlay effect (background color) covers the equivalent height of user's 
viewport, leaving empty space if the page is longer than viewport's height.

in iui.js line 451
function showDialog(page)
{
    currentDialog = page;
    page.setAttribute("selected", "true");

    if (hasClass(page, "dialog"))
    {
        showForm(page);
        page.style.height = getTotalHeight()+'px'; //add this
    }
} 

//add whole fn below
function getTotalHeight()
{
    var D = document;
    return Math.max(
        Math.max(D.body.scrollHeight, D.documentElement.scrollHeight),
        Math.max(D.body.offsetHeight, D.documentElement.offsetHeight),
        Math.max(D.body.clientHeight, D.documentElement.clientHeight)
    );
}

Original issue reported on code.google.com by spana...@gmail.com on 14 Sep 2011 at 8:00

GoogleCodeExporter commented 9 years ago

Original comment by msgilli...@gmail.com on 12 Apr 2012 at 4:36

GoogleCodeExporter commented 9 years ago 
This is a duplicate of Issue #203

Original comment by msgilli...@gmail.com on 12 Apr 2012 at 4:40