search

oulan / oppia

Automatically exported from code.google.com/p/oppia
Apache License 2.0
0 stars 0 forks source link

Code review request #661

Open GoogleCodeExporter opened 9 years ago

GoogleCodeExporter commented 9 years ago 
Branch name: separate-music-player 

Link to the relevant commit(s): 
https://code.google.com/p/oppia/source/detail?r=8cf6d866ac51fd4a30f787ffd6df5bfb
fb0268b8&name=separate-music-player#

Purpose of code changes on this branch: Pull the MIDI player out into a 
separate service so that it can be reused. (The broader purpose is because I 
thought I'd have a go at building a noninteractive "play notes as audio" RTE 
extension.)

When reviewing my code changes, please focus on: everything!

After the review, I'll merge this branch into: develop

Original issue reported on code.google.com by s...@seanlip.org on 14 Mar 2015 at 5:59

GoogleCodeExporter commented 9 years ago 
Hi Xinyu, any chance you could see whether HEAD of this branch works in your 
Firefox browser? Mike and I are getting divergent results in manual testing 
(cf. the review comments in the commit link).

Thanks!

Original comment by s...@seanlip.org on 15 Mar 2015 at 8:50

GoogleCodeExporter commented 9 years ago 
It works for me, without raising any errors. I'm using version 36.0.1.

Original comment by wxy.xi...@gmail.com on 15 Mar 2015 at 9:02

GoogleCodeExporter commented 9 years ago 
I guess it's time for me to update :p

Original comment by wagnerdm...@gmail.com on 15 Mar 2015 at 9:07