search

oulan / oppia

Automatically exported from code.google.com/p/oppia
Apache License 2.0
0 stars 0 forks source link

Code review request #664

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
Branch name:
sign_in_issue

Link to the relevant commit(s):
https://code.google.com/p/oppia/source/detail?r=5884ba272c4db1ee8c0cb98b7414e84d
fc26f97d&name=sign_in_issue

Purpose of code changes on this branch:
* On this sign-in page, I removed the "Sign in" dropdown in the top right since 
the user has already completed a login step. 
* Adding a field to indicate which email account a user is signed in with.

When reviewing my code changes, please focus on:
The changes enacted since Sean last looked at it, namely, changing the div to 
be reindented on the signup.html page, changing ng-readonly=true to 
ng-readonly="true", and bring the values['user_email'] up above the if 
statement since it's used by both.

After the review, I'll merge this branch into: develop

Original issue reported on code.google.com by maddenw...@gmail.com on 17 Mar 2015 at 12:10

GoogleCodeExporter commented 9 years ago 
Looks great, thanks Zoe!

Original comment by s...@google.com on 17 Mar 2015 at 12:13