search

oupala / apaxy

a simple, customisable theme for your apache directory listing
https://oupala.github.io/apaxy/
GNU General Public License v3.0
1.86k stars 256 forks source link

Fixes favicon not loaded when using a subdirectory #133

Closed HorlogeSkynet closed 4 years ago

HorlogeSkynet commented 4 years ago

Hey there :wave:

When Apaxy is used within a subdirectory (let's say /share), browsers would still try to load the favicon from /. This patch moves the favicon file beside its friend "theme" files and deals with the IndexHeadInsert Apache directive to point to the correct location of the set favicon.

Bye :bowing_man:

oupala commented 4 years ago

This is a great commit, I tested it and it works perfectly. I am willing to merge it.

I made a suggestion to improve your code (see in the Files changed tab).

And can you also rewrite your commit message to follow conventional changelog, as stated in the contributing doc.

HorlogeSkynet commented 4 years ago

Here you go ! My text editor caught a trailing space, I added it to my branch too. Bye :wave:

oupala commented 4 years ago

Ok, merged! Thanks @HorlogeSkynet for submitting it!

By the way, it could be a good occasion to redesign the favicon, which I made from the original logo of apaxy (see apaxy homepage):

apaxy logo

The logo is nice but the problem is that it is not very visible as a favicon. Does anyone has a suggestion?

HorlogeSkynet commented 4 years ago

Thanks @oupala !

I agree with you about its visibility. I'll try to ping a friend about it. Bye :wave: