search

oupala / apaxy

a simple, customisable theme for your apache directory listing
https://oupala.github.io/apaxy/
GNU General Public License v3.0
1.86k stars 256 forks source link

Style improvements and CSS dark mode feature #134

Closed HorlogeSkynet closed 4 years ago

HorlogeSkynet commented 4 years ago

Hey there :wave:

This is a new PR implementing a (first version of) dark mode theme for Apaxy. It uses the new prefers-color-scheme CSS media query to detect theme preference from system.

It also fixes some CSS styles by setting a correct 2-space indentation on previously existing lines.

This actually could be a WIP, up to you to decide ! Below are some screen shots of the rendering :camera:

Bye :bowing_man:

image

image

image

image

(cc @NAERNON)

HorlogeSkynet commented 4 years ago

Some screen-shots of the new rendering, with @NAERNON's latest changes :

Capture d%u2019écran 2019-08-09 à 20 58 20 Capture d%u2019écran 2019-08-09 à 20 58 28

oupala commented 4 years ago

I tested this feature and it works well. I even discovered a new css feature, thanks for that!

Before merging, could you please remove the change from the README file as they have nothing to do with the dark theme feature?

After that I'm planning to merge the pull request, except if you think it is still a work in progress (as you mentioned it in your first message).

Anyway, thanks a lot for this contribution @HorlogeSkynet and @NAERNON!

HorlogeSkynet commented 4 years ago

Hey @oupala, thanks for reviewing this. Yes the feature is (finally) finished (on our side at least), and ready for merging IMHO. I've force-pushed the branch with two style fixes and without the commit relative to README changes (I'm preparing another PR for this).

Bye, take care :wave: