Minor fixes to the error pages.

oupala / apaxy

a simple, customisable theme for your apache directory listing

https://oupala.github.io/apaxy/

GNU General Public License v3.0

1.86k stars 256 forks source link

Minor fixes to the error pages. #139

Closed sheeit closed 4 years ago

sheeit commented 4 years ago

Fixes #138

sheeit commented 4 years ago

Thanks for the report and for the merge request.

We try not to include css inside html. Can you please add the inline css into the separate css file?

Sure!

oupala commented 4 years ago

The code seems now ok. I have to check and test it.

Thank you.

oupala commented 4 years ago

Ok, the code is ok and I tested it. Nothing to say about it.

Can you please squash and rebase your commit to follow the contributing guide (this helps a lot auto-generating the changelog):

The commit message of each commit of the merge request does not follow the conventional commits standard.

In my opinion, there should only be 2 commits in the end:

Fix the doctype in the error pages.
Use style="text-algin: center" instead of

sheeit commented 4 years ago

Alright, I've done that. I had to do some reading on the git documentation, but I figured it out at the end. Cheers.

oupala commented 4 years ago

That's great, apaxy gained a better code, and on your part you learned something!