oupala / apaxy

a simple, customisable theme for your apache directory listing
https://oupala.github.io/apaxy/
GNU General Public License v3.0
1.86k stars 256 forks source link

Force certain filetypes to download (rather than display in browser) #15

Closed leek closed 6 years ago

Anahkiasen commented 10 years ago

I'm not sure about most of those, usually when I click on a JPEG or a JSON or something, I do want to open it in the browser.

Anahkiasen commented 10 years ago

Oh right missed that, my bad.

franciscolourenco commented 10 years ago

.srt should be downloaded by default no?

oupala commented 6 years ago

This branch has conflicts that must be resolved. In addition, it is old.

apaxy has been transferred to a new team and we're trying to do the housework between all pending issues and pull requests.

We decided to close this pull request. Please reclaim if you want this pull request to be re-opened, discussed and reviewed again.

Edit: you're right, this branch has no conflict.

leek commented 6 years ago

@oupala I don't use apaxy anymore, but the issue in this pull request still stands (in my opinion). When I used apaxy for a mini directory server, I didn't want things like movies and Word documents to open in the browser.

Also, I don't see any merge conflicts since the current apaxy .htaccess file is fairly basic.

oupala commented 6 years ago

On what base would you set to download or to open in the browser some particular mime-type?

In my opinion, it is hard to make someone's rule everyone's rule in this domain. I don't have anything to say about the rules that you decided, but generally speaking.

I can see some mime type that can technically be opened in the browser.

And in the end, I cannot reopen your pull request as your repository has been deleted. If you still think we need to discuss your point, can you please create a new pull request? Sorry for asking you that, especially if you don't use apaxy any more (but it would be for posterity !).