ourPLCC / plcc

A Programming Languages Compiler Compiler
GNU General Public License v3.0
8 stars 4 forks source link

Release failed? #60

Closed StoneyJackson closed 11 months ago

StoneyJackson commented 1 year ago

I just tried to merge, but it doesn't look like release did what I expected it to do. I need to investigate, but wont have time until this afternoon. I'm leaving this note as a reminder to myself, and also to let others know there is a problem in case they encounter something fishy.

StoneyJackson commented 1 year ago

sementic-release decided that the commit did not warrant a new release (https://github.com/ourPLCC/plcc/actions/runs/6482897169/job/17603319951#step:4:188).

Need to figure out what I did wrong, and how to coerce semantic-release into cutting a new release.

StoneyJackson commented 1 year ago

It looks like semantic-release (https://www.npmjs.com/package/semantic-release) does not recognize ! in the commit message prefix, even though it is part of the Conventional Commit spec (https://www.conventionalcommits.org/en/v1.0.0/). Need to figure out how to make it recognize it.

StoneyJackson commented 1 year ago

By default, semantic-release uses the "angular" preset to analyze commit messages. This preset only recognizes "BREAKING CHANGES: ..." in the body of a commit, and using an ! in the subject apparently confuses it. In Librefoodpantry, we configured semantic-release to use "conventionalcommit" preset to analyze commit messages. I think this is why it works over there. Here is the configuration file: https://gitlab.com/LibreFoodPantry/common-services/tools/release/-/blob/main/source/container/releaserc.yaml?ref_type=heads .

I think we can adapt this file for GitHub and add it as .releaserc.yaml in the root of the project. An issue on semantic-release-action's (https://github.com/codfish/semantic-release-action) site says that it should recognize this file.

github-actions[bot] commented 11 months ago

:tada: This issue has been resolved in version 5.0.0 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket: