search

ourjapanlife / findadoc-frontend

findadoc.jp web site
https://www.findadoc.jp
BSD 3-Clause "New" or "Revised" License
23 stars 17 forks source link

Suggested UI fixes for Table #63

Closed ann-kilzer closed 3 years ago

ann-kilzer commented 3 years ago

I have a few suggestions for the Table UI to better match Material UI styling

  1. Use the same button styling between the "flag" and "note", e.g. remove the blue border and have them both be icons only. Ensure that the icons are the same size and both from the Material set.
  2. "Click for more info" is a bit vague. Replace with the URL of the website (truncate to character limit and add '...' if too long)
  3. Replace the word "Flag" with "Report" (This requires an i18n change which now must be handled via the other repo)
COVID-19_Vaccination_Info
renderf0x commented 3 years ago

"Click for more info" is a bit vague. Replace with the URL of the website (truncate to character limit and add '...' if too long)

For that matter, I wonder if it might be good to have the clinic name hyperlinked in the table here as well? There's probably a future iteration where clicking it brings you to a specific clinic page on findadoc, but for now it's not even a click target...

ann-kilzer commented 3 years ago

That's a good idea!

ann-kilzer commented 3 years ago

Ahh, I see we could link the clinic name too. Will leave open but lower priority

ann-kilzer commented 3 years ago

Pardon my indecision. Going to close for now and bring it up as a design idea, but unsure if we should implement it yet.

theyokohamalife commented 3 years ago

"Click for more info" is a bit vague. Replace with the URL of the website (truncate to character limit and add '...' if too long)

For that matter, I wonder if it might be good to have the clinic name hyperlinked in the table here as well? There's probably a future iteration where clicking it brings you to a specific clinic page on findadoc, but for now it's not even a click target...

That's an excellent idea and would save us a column in the table!