ourjapanlife / findadoc-web

Front-end repository for Find a Doc, Japan
https://findadoc.jp
BSD 3-Clause "New" or "Revised" License
16 stars 14 forks source link

feat: create back button submission form modal #751

Closed ShizuokaTerrier closed 1 month ago

ShizuokaTerrier commented 1 month ago

Resolves #700

๐Ÿ”ง What changed

A modal was added that only triggers on use of the back button in the browser.

๐Ÿงช Testing instructions

No tests were added.

๐Ÿ“ธ Screenshots

It didn't exist before.

https://github.com/user-attachments/assets/62b0dcf1-436b-45ec-a8b5-77c3f0afb8f5

netlify[bot] commented 1 month ago

Deploy Preview for findadoc ready!

Name Link
Latest commit 63a074d53a3ffcdadbe74aebfcc862ab13275946
Latest deploy log https://app.netlify.com/sites/findadoc/deploys/66fa96fbceae4d00087b911f
Deploy Preview https://deploy-preview-751--findadoc.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

ShizuokaTerrier commented 1 month ago

Got a lot of support from @ProgressChris88 in the initial stage and an enormous amount of help in solving the mystery of the maddeningly inconsistent modal from @NabbeunNabi. Big thanks guys.

theyokohamalife commented 1 month ago

Great work getting the modal working! First thought that comes to mind is that we probably only want it to appear if there are actual unsaved changes. I noticed in the demo video that the modal opened if a user navigated to the edit page and hit the back button without making any changes.

theyokohamalife commented 1 month ago

Nit: As a good practice, commit message titles should be limited to about 50 characters. Anything longer than that could be added to the message body. You may want to think about how you could write this message more concisely:

Screenshot 2024-09-30 at 5 44 06โ€ฏPM
theyokohamalife commented 3 weeks ago

@all-contributors please add @ShizuokaTerrier for coding

allcontributors[bot] commented 3 weeks ago

@theyokohamalife

@ShizuokaTerrier already contributed before to code