Closed ShizuokaTerrier closed 1 month ago
Name | Link |
---|---|
Latest commit | 63a074d53a3ffcdadbe74aebfcc862ab13275946 |
Latest deploy log | https://app.netlify.com/sites/findadoc/deploys/66fa96fbceae4d00087b911f |
Deploy Preview | https://deploy-preview-751--findadoc.netlify.app |
Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site configuration.
Got a lot of support from @ProgressChris88 in the initial stage and an enormous amount of help in solving the mystery of the maddeningly inconsistent modal from @NabbeunNabi. Big thanks guys.
Great work getting the modal working! First thought that comes to mind is that we probably only want it to appear if there are actual unsaved changes. I noticed in the demo video that the modal opened if a user navigated to the edit page and hit the back button without making any changes.
Nit: As a good practice, commit message titles should be limited to about 50 characters. Anything longer than that could be added to the message body. You may want to think about how you could write this message more concisely:
@all-contributors please add @ShizuokaTerrier for coding
@theyokohamalife
@ShizuokaTerrier already contributed before to code
Resolves #700
๐ง What changed
A modal was added that only triggers on use of the back button in the browser.
๐งช Testing instructions
No tests were added.
๐ธ Screenshots
Before
It didn't exist before.
After
https://github.com/user-attachments/assets/62b0dcf1-436b-45ec-a8b5-77c3f0afb8f5