ourownstory / neural_prophet

NeuralProphet: A simple forecasting package
https://neuralprophet.com
MIT License
3.89k stars 480 forks source link

[Minor] Split prep_or_copy_df into copy and check_multiple_series_id #1647

Closed ourownstory closed 2 months ago

ourownstory commented 2 months ago

prep_or_copy_df has been called in too many places. In order to reduce complexity and redundant copies, prep_or_copy_df is split into copy and check_multiple_series_id. Calls to both have further been reduced.

github-actions[bot] commented 2 months ago

Model Benchmark

Benchmark Metric main current diff
PeytonManning MAE_val 0.35033 0.35033 0.0% :white_check_mark:
PeytonManning RMSE_val 0.50095 0.50095 0.0% :white_check_mark:
PeytonManning Loss_val 0.01775 0.01775 0.0% :white_check_mark:
PeytonManning MAE 0.34667 0.34667 0.0% :white_check_mark:
PeytonManning RMSE 0.49357 0.49357 0.0% :white_check_mark:
PeytonManning Loss 0.01466 0.01466 0.0% :white_check_mark:
PeytonManning LR 0.00032 0.00032 0.0% :white_check_mark:
PeytonManning time 14.8359 14.85 0.1% :white_check_mark:
AirPassengers MAE_val 30.1315 30.1315 0.0% :white_check_mark:
AirPassengers RMSE_val 31.0835 31.0835 0.0% :white_check_mark:
AirPassengers Loss_val 0.01242 0.01242 0.0% :white_check_mark:
AirPassengers MAE 6.12226 6.12226 0.0% :white_check_mark:
AirPassengers RMSE 7.80921 7.80921 0.0% :white_check_mark:
AirPassengers Loss 0.00064 0.00064 0.0% :white_check_mark:
AirPassengers LR 0.0004 0.0004 0.0% :white_check_mark:
AirPassengers time 8.20583 8.31 1.27% :white_check_mark:
EnergyPriceDaily MAE_val 5.40186 5.40186 0.0% :white_check_mark:
EnergyPriceDaily RMSE_val 6.70655 6.70655 0.0% :white_check_mark:
EnergyPriceDaily Loss_val 0.02519 0.02519 0.0% :white_check_mark:
EnergyPriceDaily MAE 5.91309 5.91309 0.0% :white_check_mark:
EnergyPriceDaily RMSE 7.94008 7.94008 0.0% :white_check_mark:
EnergyPriceDaily Loss 0.02554 0.02554 0.0% :white_check_mark:
EnergyPriceDaily LR 0.00029 0.00029 0.0% :white_check_mark:
EnergyPriceDaily time 19.576 19.55 -0.13% :white_check_mark:
YosemiteTemps MAE_val 0.57336 0.57336 0.0% :white_check_mark:
YosemiteTemps RMSE_val 0.84714 0.84714 0.0% :white_check_mark:
YosemiteTemps Loss_val 0.00042 0.00042 0.0% :white_check_mark:
YosemiteTemps MAE 0.93956 0.93956 0.0% :white_check_mark:
YosemiteTemps RMSE 1.65601 1.65601 0.0% :white_check_mark:
YosemiteTemps Loss 0.00118 0.00118 0.0% :white_check_mark:
YosemiteTemps LR 0.0001 0.0001 0.0% :white_check_mark:
YosemiteTemps time 58.9391 58.9 -0.07% :white_check_mark:
Model training plots ## Model Training ### PeytonManning ![](https://asset.cml.dev/1883b71e0fb1177a23f4ef47e0c04200c94ae7c7?cml=svg%2Bxml&cache-bypass=ba07927d-d539-4fbd-b2ad-146d394d70d1) ### YosemiteTemps ![](https://asset.cml.dev/b9116f2f042399fd769f80aea936568557666c6d?cml=svg%2Bxml&cache-bypass=4edfa357-24a5-4c64-941f-345bc38e3c75) ### AirPassengers ![](https://asset.cml.dev/b016ee04ce5228b96f984dcea1a0231d3d6a0e54?cml=svg%2Bxml&cache-bypass=3b6d7f03-8a38-4199-b773-2e948a474e57) ### EnergyPriceDaily ![](https://asset.cml.dev/edd965f8db66ceb9e4ba2abf9ce3bbdbb644be1f?cml=svg%2Bxml&cache-bypass=24d7630a-2fd7-40e2-9844-19d21701b768)