search

ourownstory / neural_prophet

NeuralProphet: A simple forecasting package
https://neuralprophet.com
MIT License
3.83k stars 473 forks source link

[Minor] Reduce DataFrame copies #1648

Closed ourownstory closed 2 weeks ago

ourownstory commented 2 weeks ago

Remove all copies of DataFrame except for top-level function call (when user passes df), and few necessary exceptions.

Background: Due to various pieces of code contributed by different contributors, unnecessary copies of the DataFrame were made out of precaution. This is here being addressed.

github-actions[bot] commented 2 weeks ago

Model Benchmark

Benchmark Metric main current diff
PeytonManning MAE_val 0.35033 0.35033 0.0% :white_check_mark:
PeytonManning RMSE_val 0.50095 0.50095 0.0% :white_check_mark:
PeytonManning Loss_val 0.01775 0.01775 0.0% :white_check_mark:
PeytonManning MAE 0.34667 0.34667 0.0% :white_check_mark:
PeytonManning RMSE 0.49357 0.49357 0.0% :white_check_mark:
PeytonManning Loss 0.01466 0.01466 0.0% :white_check_mark:
PeytonManning LR 0.00032 0.00032 0.0% :white_check_mark:
PeytonManning time 15.3208 14.77 -3.6% :white_check_mark:
AirPassengers MAE_val 30.1315 30.1315 0.0% :white_check_mark:
AirPassengers RMSE_val 31.0835 31.0835 0.0% :white_check_mark:
AirPassengers Loss_val 0.01242 0.01242 0.0% :white_check_mark:
AirPassengers MAE 6.12226 6.12226 0.0% :white_check_mark:
AirPassengers RMSE 7.80921 7.80921 0.0% :white_check_mark:
AirPassengers Loss 0.00064 0.00064 0.0% :white_check_mark:
AirPassengers LR 0.0004 0.0004 0.0% :white_check_mark:
AirPassengers time 8.42425 8.34 -1.0% :white_check_mark:
EnergyPriceDaily MAE_val 5.40186 5.40186 0.0% :white_check_mark:
EnergyPriceDaily RMSE_val 6.70655 6.70655 0.0% :white_check_mark:
EnergyPriceDaily Loss_val 0.02519 0.02519 0.0% :white_check_mark:
EnergyPriceDaily MAE 5.91309 5.91309 0.0% :white_check_mark:
EnergyPriceDaily RMSE 7.94008 7.94008 0.0% :white_check_mark:
EnergyPriceDaily Loss 0.02554 0.02554 0.0% :white_check_mark:
EnergyPriceDaily LR 0.00029 0.00029 0.0% :white_check_mark:
EnergyPriceDaily time 19.4359 19.89 2.34% :white_check_mark:
YosemiteTemps MAE_val 0.57336 0.57336 0.0% :white_check_mark:
YosemiteTemps RMSE_val 0.84714 0.84714 0.0% :white_check_mark:
YosemiteTemps Loss_val 0.00042 0.00042 0.0% :white_check_mark:
YosemiteTemps MAE 0.93956 0.93956 0.0% :white_check_mark:
YosemiteTemps RMSE 1.65601 1.65601 0.0% :white_check_mark:
YosemiteTemps Loss 0.00118 0.00118 0.0% :white_check_mark:
YosemiteTemps LR 0.0001 0.0001 0.0% :white_check_mark:
YosemiteTemps time 58.8034 58.23 -0.98% :white_check_mark:
Model training plots ## Model Training ### PeytonManning ![](https://asset.cml.dev/a3a6a3b1f706246c2bdd51ab6dbea5a0b1e766f9?cml=svg%2Bxml&cache-bypass=4b85c999-416d-4ed1-9f5e-89df3dae78d6) ### YosemiteTemps ![](https://asset.cml.dev/235eb18da40784af83ff22554decb6de7a0c0212?cml=svg%2Bxml&cache-bypass=e3586a2a-d120-4e04-8091-fddb0716eaf7) ### AirPassengers ![](https://asset.cml.dev/ebd5730b3a28d74de5db157574bf4a178af273e5?cml=svg%2Bxml&cache-bypass=ffe39d7d-ec85-4dfd-8360-f02553dbbaa9) ### EnergyPriceDaily ![](https://asset.cml.dev/b98867801bb918d4a8b1e10795191dfde618527a?cml=svg%2Bxml&cache-bypass=8c2332c5-3ce9-46f7-bd8a-9f5c96c78c1e)