search

ourresearch / citeas-api

Get the scholarly citation for any research product: software, preprint, paper, or dataset
https://citeas.org
MIT License
68 stars 4 forks source link

Error parsing dib-lab/sourmash #60

Closed luizirber closed 4 years ago

luizirber commented 4 years ago

Hi!

citeas is super cool! I saw an example with bokeh and tried it out with my project, sourmash... and it didn't work. From the bokeh output it seems we have even more sources (codemeta, citation.cff), but none is picked up?

While checking the API: http://api.citeas.org/product/https://github.com/dib-lab/sourmash I noticed there is an error 500, so are we doing something too weird in the repo?

caseydm commented 4 years ago

Hi! Glad you are enjoying citeas. This is fixed now. The error was on our end, in that we were not handing this portion of your codemeta file properly:

identifier: "",

We weren't treating that value as None, and were trying to parse a DOI that is sometimes there. But the script now sees that as an empty value and moves on. Take a look and let me know if you see any other issues.

luizirber commented 4 years ago

Thanks for the quick reply, @caseydm!

And... That's an error on our side, that identifier should be a DOI, and we should have authors listed too :rofl:. I'll fix it and try again, but already glad to see it is showing up on citeas!