oursky / django-material-demo

0 stars 3 forks source link

Pre-defined filtering in list page #14

Closed Steven-Chan closed 2 years ago

Steven-Chan commented 2 years ago
tung2744 commented 2 years ago

@Steven-Chan Would like to know if there are any planning on how to implement this? Because django material seems only support filters in pro, so we will implement it on our own?

Steven-Chan commented 2 years ago

@tung2744 @Rubikium In our another project there is filtering on the RHS of the list.

image

There are also similar filtering in the demo site http://demo.viewflow.io/integration/city/ and http://demo.viewflow.io/employees/employees/. And they are text input and drop down select.

In this task, I expect we need to explore the effort on putting other kinds of input in the filter section.

tung2744 commented 2 years ago

@Steven-Chan I believe that is only available in PRO, as I looked into their source code and found there should be no way to configure those filters easily. See this template. And another project here: https://github.com/oursky/fairwood/blob/dev/services/cms/cms/views/material.py#L96 You can see we make the filters manually.

Steven-Chan commented 2 years ago

@tung2744 I think it is unavoidable to include this in demo even if we need to implement ourselves, just like nesting form. This feature is too common. We will need to answer other colleagues questions on how much effort and complexity needed to the project if they need to add this feature.

Steven-Chan commented 2 years ago

I think the good news is, this feature is PRO only, which means we can implement this in the way that it originally designed. Don't need to design ourselves in the risk of breaking the framework design principle.